Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1196733004: Reconfigured options for sym_upload to not treat h and ? flags as invalid options. (Closed)

Created:
5 years, 6 months ago by ivanpe
Modified:
5 years, 6 months ago
Reviewers:
Jess, mmandlis
CC:
google-breakpad-dev_googlegroups.com, Andrew Liu
Visibility:
Public.

Description

Reconfigured options for sym_upload to not treat h and ? flags as invalid options. I'm submitting this on behalf of Andrew Liu. R=mmandlis@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1462

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/tools/linux/symupload/sym_upload.cc View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
ivanpe
5 years, 6 months ago (2015-06-20 00:28:06 UTC) #2
mmandlis
lgtm https://codereview.chromium.org/1196733004/diff/1/src/tools/linux/symupload/sym_upload.cc File src/tools/linux/symupload/sym_upload.cc (right): https://codereview.chromium.org/1196733004/diff/1/src/tools/linux/symupload/sym_upload.cc#newcode199 src/tools/linux/symupload/sym_upload.cc:199: break; nit - do you really need the ...
5 years, 6 months ago (2015-06-22 16:51:59 UTC) #3
ivanpe
https://codereview.chromium.org/1196733004/diff/1/src/tools/linux/symupload/sym_upload.cc File src/tools/linux/symupload/sym_upload.cc (right): https://codereview.chromium.org/1196733004/diff/1/src/tools/linux/symupload/sym_upload.cc#newcode199 src/tools/linux/symupload/sym_upload.cc:199: break; On 2015/06/22 16:51:59, mmandlis wrote: > nit - ...
5 years, 6 months ago (2015-06-22 21:18:10 UTC) #4
ivanpe
5 years, 6 months ago (2015-06-22 21:21:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r1462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698