Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(151)

Issue 1196733003: Remove duplicate Encoding API tests (Closed)

Created:
4 years, 10 months ago by jsbell
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove duplicate Encoding API tests Several of the fast/encoding/api tests were upstreamed to web-platform-tests and can be deleted. A few were redundant already or had cases shuffled between files. fast/encoding/api imported/web-platform-tests/encoding ----------------------------------------------------------------- basics.html api-basics.html byte-order-marks.html textdecoder-byte-order-marks.html encoding-labels.html textdecoder-labels.html encoding-names.html textdecoder-labels.html end-of-file.html textdecoder-fatal-streaming.html fatal-flag.html textdecoder-fatal.html legacy-encode.html textencoder-constructor-non-utf.html replacement-encoding.html api-replacement-encodings.html streaming-decode.html textdecoder-streaming.html textdecoder-ignorebom.html textdecoder-ignorebom.html textdecoder-labels.html textdecoder-labels.html utf16-surrogates-encode.html textencoder-utf16-surrogates.html utf16-surrogates.html textdecoder-utf16-surrogates.html utf8-surrogates.html api-surrogates-utf8.html Also rename resources/shared.js to resources/encodings.js to align with web-platform-tests's equivalent. R=dpranke@chromium.org BUG=493927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1108 lines) Patch
M LayoutTests/fast/encoding/api/ascii-supersets.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/encoding/api/basics.html View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/fast/encoding/api/byte-order-marks.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/encoding/api/encoding-labels.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/encoding/api/encoding-names.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/encoding/api/end-of-file.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/fast/encoding/api/fatal-flag.html View 1 chunk +0 lines, -73 lines 0 comments Download
M LayoutTests/fast/encoding/api/latin-1.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/encoding/api/legacy-encode.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/encoding/api/replacement-encoding.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + LayoutTests/fast/encoding/api/resources/encodings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/encoding/api/resources/shared.js View 1 chunk +0 lines, -465 lines 0 comments Download
D LayoutTests/fast/encoding/api/streaming-decode.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/encoding/api/textdecoder-ignorebom.html View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/fast/encoding/api/textdecoder-labels.html View 1 chunk +0 lines, -51 lines 0 comments Download
M LayoutTests/fast/encoding/api/textencoder-labels.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/api/utf-round-trip.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/encoding/api/utf16-surrogates.html View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/fast/encoding/api/utf16-surrogates-encode.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/fast/encoding/api/utf16-surrogates-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/encoding/api/utf8-surrogates.html View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jsbell
dpranke@ - ptal?
4 years, 10 months ago (2015-06-19 21:49:14 UTC) #1
Dirk Pranke
lgtm
4 years, 10 months ago (2015-06-19 23:53:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196733003/1
4 years, 10 months ago (2015-06-20 02:41:15 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2015-06-20 03:40:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197525

Powered by Google App Engine
This is Rietveld 408576698