Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: dart/runtime/vm/intermediate_language_mips.cc

Issue 119673004: Version 1.1.0-dev.5.2 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/runtime/vm/intermediate_language_ia32.cc ('k') | dart/runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/vm/intermediate_language_mips.cc
===================================================================
--- dart/runtime/vm/intermediate_language_mips.cc (revision 31530)
+++ dart/runtime/vm/intermediate_language_mips.cc (working copy)
@@ -101,13 +101,7 @@
__ Bind(&stack_ok);
}
#endif
- // This sequence is patched by a debugger breakpoint. There is no need for
- // extra NOP instructions here because the sequence patched in for a
- // breakpoint is shorter than the sequence here.
__ LeaveDartFrameAndReturn();
- compiler->AddCurrentDescriptor(PcDescriptors::kReturn,
- Isolate::kNoDeoptId,
- token_pos());
}
@@ -810,6 +804,32 @@
}
+LocationSummary* StringToCharCodeInstr::MakeLocationSummary(bool opt) const {
+ const intptr_t kNumInputs = 1;
+ return LocationSummary::Make(kNumInputs,
+ Location::RequiresRegister(),
+ LocationSummary::kNoCall);
+}
+
+
+void StringToCharCodeInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ __ TraceSimMsg("StringToCharCodeInstr");
+
+ ASSERT(cid_ == kOneByteStringCid);
+ Register str = locs()->in(0).reg();
+ Register result = locs()->out().reg();
+ Label done, is_one;
+ __ lw(result, FieldAddress(str, String::length_offset()));
+ __ BranchEqual(result, Smi::RawValue(1), &is_one);
+ __ LoadImmediate(result, Smi::RawValue(-1));
+ __ b(&done);
+ __ Bind(&is_one);
+ __ lbu(result, FieldAddress(str, OneByteString::data_offset()));
+ __ SmiTag(result);
+ __ Bind(&done);
+}
+
+
LocationSummary* StringInterpolateInstr::MakeLocationSummary(bool opt) const {
const intptr_t kNumInputs = 1;
const intptr_t kNumTemps = 0;
« no previous file with comments | « dart/runtime/vm/intermediate_language_ia32.cc ('k') | dart/runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698