dart/runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html - Issue 119673004: Version 1.1.0-dev.5.2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html

Issue 119673004: Version 1.1.0-dev.5.2 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html ('k') | dart/runtime/bin/vmservice/client/lib/src/observatory_elements/function_ref.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html

===================================================================

--- dart/runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html (revision 31530)

+++ dart/runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html (working copy)

@@ -1,4 +1,5 @@

<head>

+ <link rel="import" href="class_ref.html">

</head>

<polymer-element name="field-view" extends="observatory-element">

@@ -10,10 +11,8 @@

<template if="{{ field['static'] }}">static</template>

<template if="{{ field['final'] }}">final</template>

<template if="{{ field['const'] }}">const</template>

- {{ field['user_name'] }} ({{ field['name'] }})

- <a class="pull-right" href="{{ app.locationManager.currentIsolateClassLink(field['class']['id'])}}">

- {{ field['class']['user_name'] }}

- </a>

+ {{ field['user_name'] }} ({{ field['name'] }})

+ <class-ref app="{{ app }}" ref="{{ field['class'] }}"></class-ref>

</div>

@@ -22,9 +21,9 @@

assigned a single type, performance may improve.

</div>

</template>

- <template if="{{ field['guard_class'] != 'dynamic'}}">

+ <template if="{{ (field['guard_class'] != 'dynamic') && (field['guard_class'] != 'unknown') }}">

<div class="alert alert-success">Field has monomorphic type</div>

- <template if="{{ (field['guard_class'] != 'dynamic') &&

+ <template if="{{ (field['guard_class'] != 'dynamic') &&

field['guard_nullable'] }}">

Field has been assigned null. If a field is never assigned null,

@@ -32,9 +31,7 @@

</div>

</template>

- <a href="{{ app.locationManager.currentIsolateClassLink(field['guard_class']['id'])}}">

- {{ field['guard_class']['user_name'] }}

- </a>

+ <class-ref app="{{ app }}" ref="{{ field['guard_class'] }}"></class-ref>

</blockquote>

</template>

</div>