Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: dart/runtime/vm/debugger_ia32.cc

Issue 119673004: Version 1.1.0-dev.5.2 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/runtime/vm/debugger_arm.cc ('k') | dart/runtime/vm/debugger_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/vm/debugger_ia32.cc
===================================================================
--- dart/runtime/vm/debugger_ia32.cc (revision 31530)
+++ dart/runtime/vm/debugger_ia32.cc (working copy)
@@ -36,35 +36,6 @@
*reinterpret_cast<uword*>(closure_addr));
}
-
-void CodeBreakpoint::PatchFunctionReturn() {
- uint8_t* code = reinterpret_cast<uint8_t*>(pc_ - 5);
- ASSERT((code[0] == 0x89) && (code[1] == 0xEC)); // mov esp,ebp
- ASSERT(code[2] == 0x5D); // pop ebp
- ASSERT(code[3] == 0xC3); // ret
- ASSERT(code[4] == 0x90); // nop
-
- // Smash code with call instruction and relative target address.
- uword stub_addr = StubCode::BreakpointReturnEntryPoint();
- code[0] = 0xE8;
- *reinterpret_cast<uword*>(&code[1]) = stub_addr - pc_;
- CPU::FlushICache(pc_ - 5, 5);
-}
-
-
-void CodeBreakpoint::RestoreFunctionReturn() {
- uint8_t* code = reinterpret_cast<uint8_t*>(pc_ - 5);
- ASSERT(code[0] == 0xE8);
- code[0] = 0x89;
- code[1] = 0xEC; // mov esp,ebp
- code[2] = 0x5D; // pop ebp
- code[3] = 0xC3; // ret
- code[4] = 0x90; // nop
- CPU::FlushICache(pc_ - 5, 5);
-}
-
-
-
} // namespace dart
#endif // defined TARGET_ARCH_IA32
« no previous file with comments | « dart/runtime/vm/debugger_arm.cc ('k') | dart/runtime/vm/debugger_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698