Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: dart/runtime/vm/debugger_api_impl_test.cc

Issue 119673004: Version 1.1.0-dev.5.2 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/runtime/vm/debugger.cc ('k') | dart/runtime/vm/debugger_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/vm/debugger_api_impl_test.cc
===================================================================
--- dart/runtime/vm/debugger_api_impl_test.cc (revision 31530)
+++ dart/runtime/vm/debugger_api_impl_test.cc (working copy)
@@ -647,28 +647,28 @@
EXPECT(breakpoint_hit == true);
}
+static const char* step_into_expected_bpts[] = {
+ "main",
+ "foo",
+ "f1",
+ "foo",
+ "X.X.",
+ "X.X.",
+ "foo",
+ "X.kvmk",
+ "f2",
+ "X.kvmk",
+ "X.kvmk",
+ "foo",
+ "main"
+};
void TestStepIntoHandler(Dart_IsolateId isolate_id,
intptr_t bp_id,
const Dart_CodeLocation& location) {
Dart_StackTrace trace;
Dart_GetStackTrace(&trace);
- const char* expected_bpts[] = {
- "main",
- "foo",
- "f1",
- "foo",
- "X.X.",
- "X.X.",
- "foo",
- "X.kvmk",
- "f2",
- "X.kvmk",
- "X.kvmk",
- "foo",
- "main"
- };
- const intptr_t expected_bpts_length = ARRAY_SIZE(expected_bpts);
+ const intptr_t expected_bpts_length = ARRAY_SIZE(step_into_expected_bpts);
intptr_t trace_len;
Dart_Handle res = Dart_StackTraceLength(trace, &trace_len);
EXPECT_VALID(res);
@@ -683,7 +683,7 @@
const char* name_chars;
Dart_StringToCString(func_name, &name_chars);
if (breakpoint_hit_counter < expected_bpts_length) {
- EXPECT_STREQ(expected_bpts[breakpoint_hit_counter], name_chars);
+ EXPECT_STREQ(step_into_expected_bpts[breakpoint_hit_counter], name_chars);
}
if (verbose) {
OS::Print(" >> bpt nr %d: %s\n", breakpoint_hit_counter, name_chars);
@@ -727,6 +727,7 @@
int64_t int_value = ToInt64(retval);
EXPECT_EQ(7, int_value);
EXPECT(breakpoint_hit == true);
+ EXPECT(breakpoint_hit_counter == ARRAY_SIZE(step_into_expected_bpts));
}
« no previous file with comments | « dart/runtime/vm/debugger.cc ('k') | dart/runtime/vm/debugger_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698