[Android] Sever findbugs dependencies on environment variables.

tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py

Index: tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py
diff --git a/tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py b/tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py
index 1115192fb44a78a7c451caebabb4f476d0b9f02a..8af0fa611f2601d8ffd5cb56b19bd213f12e9eee 100755
--- a/tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py
+++ b/tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py
@@ -5,7 +5,7 @@
 # found in the LICENSE file.
 
 # This is used to test the findbugs plugin, it calls
-# build/android/pylib/findbugs.py to analyze the classes in
+# build/android/pylib/utils/findbugs.py to analyze the classes in
 # org.chromium.tools.findbugs.plugin package, and expects to get the same
 # issue with those in expected_result.txt.
 #
@@ -18,17 +18,14 @@ import optparse
 import os
 import sys
 
-lib_folder = os.path.join(os.getenv('CHROME_SRC'), 'build', 'android', 'pylib')
+lib_folder = os.path.join(os.getenv('CHROME_SRC'), 'build', 'android')

[frankf, 2013/01/16 19:22:23]

Nit: Use pylib constants here too.

[Yaron, 2013/01/16 20:30:53]

I can't because we're using this to get the path to pylib. Changed to using
offset from __file__ and changed the lower usage to constants.

 if lib_folder not in sys.path:
   sys.path.append(lib_folder)
 
-import findbugs
+from pylib.utils import findbugs
 
 
 def main(argv):
-  if not findbugs.CheckEnvironment():
-    return 1
-
   parser = findbugs.GetCommonParser()
 
   options, _ = parser.parse_args()