[Android] Sever findbugs dependencies on environment variables.

build/android/findbugs_diff.py

Index: build/android/findbugs_diff.py
diff --git a/build/android/findbugs_diff.py b/build/android/findbugs_diff.py
index eb49824ef2375c1c013a31ea607a8da4cb55b8a2..eb9fa531e5220b4d6450991a870f0deed33153c2 100755
--- a/build/android/findbugs_diff.py
+++ b/build/android/findbugs_diff.py
@@ -28,21 +28,17 @@ import optparse
 import os
 import sys
 
+from pylib import constants
 from pylib import findbugs

[frankf, 2013/01/16 18:10:46]

while you're here, move findbugs to pylib/utils?

[Yaron, 2013/01/16 18:15:28]

How do you decide what goes in utils?

 
 
 def main(argv):
-  if not findbugs.CheckEnvironment():
-    return 1
-
   parser = findbugs.GetCommonParser()
 
   options, _ = parser.parse_args()
 
-  chrome_src = os.getenv('CHROME_SRC')
-
   if not options.base_dir:
-    options.base_dir = os.path.join(chrome_src, 'build', 'android',
+    options.base_dir = os.path.join(constants.CHROME_DIR, 'build', 'android',
                                     'findbugs_filter')
   if not options.only_analyze:
     options.only_analyze = 'org.chromium.-'