Hide location bar on WebKit programmatic scroll.

cc/input/top_controls_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/input/top_controls_manager.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/time.h"
@@ skipping 49 matching lines @@
 
   if (!enable) {
     ResetAnimations();
     if (controls_top_offset_ != 0) {
       SetupAnimation(SHOWING_CONTROLS);
       client_->setNeedsRedraw();
     }
   }
 }
 
+void TopControlsManager::ShowTopControls(bool show) {
+  if (show) {
+    if (controls_top_offset_ == 0)

[aelias_OOO_until_Jul13, 2013/03/25 22:35:44]

Please add these two early outs to SetupAnimation instead.

[John Knottenbelt, 2013/03/26 14:49:17]

Done.

+      return;
+    SetupAnimation(SHOWING_CONTROLS);
+  } else {
+    DCHECK(enable_hiding_);
+    if (controls_top_offset_ == -top_controls_height_)
+      return;
+    SetupAnimation(HIDING_CONTROLS);
+  }

[aelias_OOO_until_Jul13, 2013/03/25 22:35:44]

Looks like you're missing a client_->setNeedsRedraw() here.  The other callers
of SetupAnimation all do it, and it's needed to reliably kick off the animation.
 I recommend adding setNeedsRedraw to the end of SetupAnimation and removing it
from the other callsites.

[John Knottenbelt, 2013/03/26 14:49:17]

Done.

+}
+
 void TopControlsManager::ScrollBegin() {
   ResetAnimations();
   current_scroll_delta_ = 0.f;
   controls_scroll_begin_offset_ = controls_top_offset_;
 }
 
 gfx::Vector2dF TopControlsManager::ScrollBy(
     const gfx::Vector2dF pending_delta) {
   if (!enable_hiding_ && pending_delta.y() > 0)
     return pending_delta;
@@ skipping 108 matching lines @@
 
   if ((animation_direction_ == SHOWING_CONTROLS && new_offset >= 0) ||
       (animation_direction_ == HIDING_CONTROLS
           && new_offset <= -top_controls_height_)) {
     return true;
   }
   return false;
 }
 
 }  // namespace cc