Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 11967009: Revert "Optimize the emitted instruction of random function for X64" (Closed)

Created:
7 years, 11 months ago by Jakob Kummerow
Modified:
7 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev, weiliang.lin2
Visibility:
Public.

Description

Revert "Optimize the emitted instruction of random function for X64" This reverts r13393. Committed: http://code.google.com/p/v8/source/detail?r=13396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M src/x64/assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +22 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
Crashes on Win64: http://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/3798/steps/Check/logs/stdio
7 years, 11 months ago (2013-01-16 11:43:25 UTC) #1
Yang
7 years, 11 months ago (2013-01-16 11:43:54 UTC) #2
On 2013/01/16 11:43:25, Jakob wrote:
> Crashes on Win64:
>
http://build.chromium.org/p/client.v8/builders/V8%2520Win64/builds/3798/steps...

LGTM.

Powered by Google App Engine
This is Rietveld 408576698