Issue 11967005: Re-land "[Android] Generate localized strings.xml files at build time."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11967005: Re-land "[Android] Generate localized strings.xml files at build time." (Closed)

Created:
7 years, 11 months ago by newt (away)

Modified:
7 years, 11 months ago

Reviewers:
shashi, cjhopman, Yaron, jam, (unused - use chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-land "[Android] Generate localized strings.xml files at build time." This generates localized strings.xml files (e.g. values-fr/strings.xml) from grd and xtb files at build time. This means we no longer need to check in localized strings.xml files. Note: the xtb files are empty until translations are available. Benefits: - 41 fewer extraneous results when grepping Java string IDs - Switching from maintaining strings in strings.xml over to using a grd file is One Trivial CL* away: just include English in the list of languages for which we generate strings.xml files. *Restrictions may apply Originally landed as https://codereview.chromium.org/11659006/ This can be re-landed as of https://codereview.chromium.org/11880050/ BUG=167248 TBR=yfriedman@chromium.org,thakis,jam@chromium.org,cjhopman,shashishekhar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177170

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -14 lines)			Patch
M	build/java.gypi	View	4 chunks	+33 lines, -3 lines	0 comments	Download
M	build/java_apk.gypi	View	5 chunks	+42 lines, -11 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11967005/1

7 years, 11 months ago (2013-01-16 02:14:16 UTC) #1

commit-bot: I haz the power

Retried try job too often on win for step(s) compile

7 years, 11 months ago (2013-01-16 04:26:52 UTC) #2

commit-bot: I haz the power

7 years, 11 months ago (2013-01-16 17:25:09 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/11967005/1