Instrument early NaCl load failiures on Windows.

Instrument early NaCl load failiures on Windows.

BUG=164462
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177273

[Mark Seaborn, 2013-01-16 00:27:54]

LGTM.  I'd be happier if this were not reverted later. :-)  Logging is important
for being able to track down failures.

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:274: "resources needed to launch
the process.";
This is being picky, but most log messages in Chrome don't end with a "."

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:576: weak_factory_.GetWeakPtr(),
channel_id)) {
Indent function argument

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:620: LOG(ERROR) << "NaCl process
launch failed: could not aquire shared "
"acquire"

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:868: LOG(ERROR) << "NaCl process
failed to launch: previously failed to aquire "
"acquire"

[Nick Bray (chromium), 2013-01-16 05:54:52]

PTAL, unsure what to do with the indentation.

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:274: "resources needed to launch
the process.";
On 2013/01/16 00:27:54, Mark Seaborn wrote:
> This is being picky, but most log messages in Chrome don't end with a "."

Done.

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:576: weak_factory_.GetWeakPtr(),
channel_id)) {
On 2013/01/16 00:27:54, Mark Seaborn wrote:
> Indent function argument

How?  This is technically indented 2x relative to the start of the first line. 
Breaking the line before and indented block is strange.

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:620: LOG(ERROR) << "NaCl process
launch failed: could not aquire shared "
On 2013/01/16 00:27:54, Mark Seaborn wrote:
> "acquire"

Done.

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:868: LOG(ERROR) << "NaCl process
failed to launch: previously failed to aquire "
On 2013/01/16 00:27:54, Mark Seaborn wrote:
> "acquire"

Done.

[Mark Seaborn, 2013-01-16 16:03:50]

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

https://codereview.chromium.org/11967002/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_process_host.cc:576: weak_factory_.GetWeakPtr(),
channel_id)) {
On 2013/01/16 05:54:52, Nick Bray (chromium) wrote:
> On 2013/01/16 00:27:54, Mark Seaborn wrote:
> > Indent function argument
> 
> How?  This is technically indented 2x relative to the start of the first line.

> Breaking the line before and indented block is strange.

You should write

if (!NaClBrokerService::GetInstance()->LaunchLoader(
         weak_factory_.GetWeakPtr(), channel_id)) {

rather than

if (!NaClBrokerService::GetInstance()->LaunchLoader(
    weak_factory_.GetWeakPtr(), channel_id)) {

The latter is rather like writing this outside of an if():

NaClBrokerService::GetInstance()->LaunchLoader(
weak_factory_.GetWeakPtr(), channel_id);

[commit-bot: I haz the power, 2013-01-16 20:17:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncbray@chromium.org/11967002/5001

[commit-bot: I haz the power, 2013-01-16 21:06:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncbray@chromium.org/11967002/4

[commit-bot: I haz the power, 2013-01-17 00:00:36]

Change committed as 177273