Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.h

Issue 1196663005: [chromedriver] When launching a Chrome App, automatically switch to the new window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
index 3b13b678ad86df0a54001118eb8f5febaac926a7..67611c6cc561bb768e808cd59383830525a0b6f2 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
@@ -57,6 +57,10 @@ class ChromeDesktopImpl : public ChromeImpl {
const base::CommandLine& command() const;
+ Status WaitForNewAppWindow(const std::string& extension_id,
stgao 2015/06/26 17:55:47 should it be app_id instead of extension_id?
samuong 2015/06/26 18:09:26 Done. This is essentially the same thing, since bo
+ std::string* web_view_id,
stgao 2015/06/26 17:55:47 IMHO, the output parameters usually go at the end
samuong 2015/06/26 18:09:26 Done.
+ const base::TimeDelta& timeout);
+
private:
base::Process process_;
base::CommandLine command_;
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698