Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1196633002: Add vivek.vg@samsung.com to Source/bindings/OWNERS (Closed)

Created:
5 years, 6 months ago by vivekg_samsung
Modified:
5 years, 6 months ago
Reviewers:
haraken, vivekg
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add vivek.vg@samsung.com to Source/bindings/OWNERS With the focus being on blink bindings, I started working on blink-in-js framework. As I got more comfortable with bindings in general, moved on to remove the custom bindings usage along with improving the support for using WebIDL syntax more. Also participated in bindings related code reviews to gain in-depth knowledge about the interworkings of binding with rest of the blink. This provided me the opportunity to build up the confidence required for being an OWNER. This will help me to contribute more effectively and be part of reviews and provide insights about the recent changes and future changes if any. Also this would help fellow samsung peers. I can also help keeping the custom bindings at the bay by lowering its usage. NOTRY=true R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/bindings/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL :) Thank you!
5 years, 6 months ago (2015-06-19 12:38:10 UTC) #2
haraken
LGTM!
5 years, 6 months ago (2015-06-19 12:49:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196633002/1
5 years, 6 months ago (2015-06-19 13:16:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197468
5 years, 6 months ago (2015-06-19 13:20:11 UTC) #6
vivekg
5 years, 6 months ago (2015-06-19 13:22:22 UTC) #7
Message was sent while issue was closed.
On 2015/06/19 at 12:49:17, haraken wrote:
> LGTM!

Thanks a ton haraken! :)

Powered by Google App Engine
This is Rietveld 408576698