src/compiler/common-operator-reducer.cc - Issue 1196623002: [ubsan] Fix HeapObjectMatcher to avoid invalid casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/common-operator-reducer.cc

Issue 1196623002: [ubsan] Fix HeapObjectMatcher to avoid invalid casts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/common-operator-reducer.cc

diff --git a/src/compiler/common-operator-reducer.cc b/src/compiler/common-operator-reducer.cc

index 35f405bf3d82f4de9e1c9ef4ceb34e3b1cf4fb40..4bab1204787d1414c518112afbdab0c0c13c1073 100644

--- a/src/compiler/common-operator-reducer.cc

+++ b/src/compiler/common-operator-reducer.cc

@@ -31,7 +31,7 @@ Decision DecideCondition(Node* const cond) {

return mcond.Value() ? Decision::kTrue : Decision::kFalse;

}

case IrOpcode::kHeapConstant: {

- HeapObjectMatcher<HeapObject> mcond(cond);

+ HeapObjectMatcher mcond(cond);

return mcond.Value().handle()->BooleanValue() ? Decision::kTrue

: Decision::kFalse;

}