cc/layers/picture_layer_impl_unittest.cc - Issue 1196553009: Revert "cc: Make tiling interest rect calc based on viewport."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 1196553009: Revert "cc: Make tiling interest rect calc based on viewport." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert some follow up perf test code too. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl_unittest.cc

diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc

index 83e37a092345282617371b06fb645ea7a42fd323..bbfcffb83cf7ec82b63a61787169b16857ed0890 100644

--- a/cc/layers/picture_layer_impl_unittest.cc

+++ b/cc/layers/picture_layer_impl_unittest.cc

@@ -2488,8 +2488,8 @@ TEST_F(PictureLayerImplTest, RequiredTilesWithGpuRasterization) {

active_layer_->HighResTiling()->UpdateAllRequiredStateForTesting();

- // High res tiling should have 36 tiles (3X12 tile grid).

- EXPECT_EQ(36u, active_layer_->HighResTiling()->AllTilesForTesting().size());

+ // High res tiling should have 64 tiles (4x16 tile grid).

+ EXPECT_EQ(64u, active_layer_->HighResTiling()->AllTilesForTesting().size());

// Visible viewport should be covered by 4 tiles. No other

// tiles should be required for activation.

« no previous file with comments | « cc/layers/picture_layer_impl_perftest.cc ('k') | cc/tiles/picture_layer_tiling.h » ('j') | cc/tiles/tile_manager_perftest.cc » ('J')