Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: sky/sdk/lib/rendering/box.dart

Issue 1196553004: Short-circuit the relayoutSubtreeRoot when the child couldn't change dimensions anyway because the … (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/rendering/sector_layout.dart ('k') | sky/sdk/lib/rendering/object.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/rendering/box.dart
diff --git a/sky/sdk/lib/rendering/box.dart b/sky/sdk/lib/rendering/box.dart
index bd71c167823c3059fc7e0ea2990ee9ed004fb9a2..55017dc42323d2b6847830f9e5cfcf2172d16fcf 100644
--- a/sky/sdk/lib/rendering/box.dart
+++ b/sky/sdk/lib/rendering/box.dart
@@ -63,7 +63,7 @@ class EdgeDims {
String toString() => "EdgeDims($top, $right, $bottom, $left)";
}
-class BoxConstraints {
+class BoxConstraints extends Constraints {
const BoxConstraints({
this.minWidth: 0.0,
this.maxWidth: double.INFINITY,
@@ -185,8 +185,8 @@ class BoxConstraints {
bool get isInfinite => maxWidth >= double.INFINITY && maxHeight >= double.INFINITY;
- bool get hasTightWidth => minWidth == maxWidth;
- bool get hasTightHeight => minHeight == maxHeight;
+ bool get hasTightWidth => minWidth >= maxWidth;
+ bool get hasTightHeight => minHeight >= maxHeight;
bool get isTight => hasTightWidth && hasTightHeight;
bool operator ==(other) {
« no previous file with comments | « sky/examples/rendering/sector_layout.dart ('k') | sky/sdk/lib/rendering/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698