src/elements.cc - Issue 1196533004: Remove duplicate isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 1196533004: Remove duplicate isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index 0ddd11b4dded3edda74db5093d79c73a4f576648..e7e0e7f76adcf7fe3c1d0967f4d59176644558e1 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -1336,7 +1336,6 @@ class DictionaryElementsAccessor

if (length <= Smi::kMaxValue) {

array->set_length(Smi::FromInt(length));

} else {

- Isolate* isolate = array->GetIsolate();

Handle<Object> length_obj = isolate->factory()->NewNumberFromUint(length);

array->set_length(*length_obj);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »