Issue 1196533002: Clean up fast path CSS color parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1196533002: Clean up fast path CSS color parsing (Closed)

Created:
5 years, 6 months ago by Timothy Loh

Modified:
5 years, 6 months ago

Reviewers:
alancutter (OOO until 2018)

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clean up fast path CSS color parsing This patch cleans up the CSSParserFastPaths interface to parsing colors, making it the same interface as what it uses in maybeParseValue. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197443

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -39 lines)			Patch
M	Source/core/css/parser/CSSParser.cpp	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	Source/core/css/parser/CSSParserFastPaths.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/css/parser/CSSParserFastPaths.cpp	View	2 chunks	+14 lines, -27 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196533002/1

5 years, 6 months ago (2015-06-19 06:35:09 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-19 06:39:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197443

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages