Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1196523002: Reapply Foxit's libopenjpeg modifications. (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply Foxit's libopenjpeg modifications. They were lost in commit d53e6fd. BUG=pdfium:168 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/870b5b6793fa261f0c6f31f026010d2d715968bf

Patch Set 1 #

Patch Set 2 : rebase, invert logic #

Total comments: 1

Patch Set 3 : README.pdfium #

Patch Set 4 : with test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
A testing/resources/pixel/bug_71.in View 1 2 3 Binary file 0 comments Download
A testing/resources/pixel/bug_71_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
A third_party/libopenjpeg20/0000-use-colorspace.patch View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/libopenjpeg20/README.pdfium View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/libopenjpeg20/jp2.c View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libopenjpeg20/openjpeg.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
Lei Zhang
See the discussion on the bug. There's probably an entire class of PDFs that are ...
5 years, 3 months ago (2015-09-01 23:01:14 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1196523002/diff/20001/third_party/libopenjpeg20/openjpeg.h File third_party/libopenjpeg20/openjpeg.h (right): https://codereview.chromium.org/1196523002/diff/20001/third_party/libopenjpeg20/openjpeg.h#newcode681 third_party/libopenjpeg20/openjpeg.h:681: /** Whether to apply PCLR or not */ ...
5 years, 3 months ago (2015-09-01 23:07:49 UTC) #3
Tom Sepez
On 2015/09/01 23:07:49, Tom Sepez wrote: > lgtm > > https://codereview.chromium.org/1196523002/diff/20001/third_party/libopenjpeg20/openjpeg.h > File third_party/libopenjpeg20/openjpeg.h (right): ...
5 years, 3 months ago (2015-09-01 23:09:38 UTC) #4
Tom Sepez
Oh, and a test case.
5 years, 3 months ago (2015-09-01 23:10:19 UTC) #5
Tom Sepez
On 2015/09/01 23:10:19, Tom Sepez wrote: > Oh, and a test case. But other than ...
5 years, 3 months ago (2015-09-01 23:10:32 UTC) #6
Lei Zhang
On 2015/09/01 23:09:38, Tom Sepez wrote: > Or a third_party/libopenjpeg20/README_PDFium file that talks about the ...
5 years, 3 months ago (2015-09-02 01:26:58 UTC) #7
Lei Zhang
On 2015/09/01 23:10:19, Tom Sepez wrote: > Oh, and a test case. I'll write a ...
5 years, 3 months ago (2015-09-02 01:30:50 UTC) #8
Lei Zhang
On 2015/09/02 01:30:50, Lei Zhang wrote: > On 2015/09/01 23:10:19, Tom Sepez wrote: > > ...
5 years, 3 months ago (2015-09-02 01:43:39 UTC) #9
Lei Zhang
PTAL at patch set 4.
5 years, 3 months ago (2015-09-02 06:59:41 UTC) #10
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-02 19:48:10 UTC) #11
Lei Zhang
Committed patchset #4 (id:60001) manually as 870b5b6793fa261f0c6f31f026010d2d715968bf (presubmit successful).
5 years, 3 months ago (2015-09-02 20:52:06 UTC) #12
Lei Zhang
The Windows bot failed. I'm guessing something is wrong with the bug_71.in to bug_71.pdf generation.
5 years, 3 months ago (2015-09-02 21:00:59 UTC) #13
Lei Zhang
5 years, 3 months ago (2015-09-02 23:45:11 UTC) #14
Message was sent while issue was closed.
On 2015/09/02 21:00:59, Lei Zhang wrote:
> The Windows bot failed. I'm guessing something is wrong with the bug_71.in to
> bug_71.pdf generation.

FTR, https://codereview.chromium.org/1312493006/ is the follow up CL.

Powered by Google App Engine
This is Rietveld 408576698