Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196453003: chromoting: Add JS externs for qunit. (Closed)

Created:
5 years, 6 months ago by James Hawkins
Modified:
5 years, 6 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromoting: Add JS externs for qunit. This is one of a few fixes needed to enable ES6 mode in remoting/. BUG=481705 Committed: https://crrev.com/ffbf1b6110ff79b0f9683a4f4acc67baf4900499 Cr-Commit-Position: refs/heads/master@{#335097}

Patch Set 1 #

Patch Set 2 : Format .gn file. #

Patch Set 3 : Don't forget the gypi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -47 lines) Patch
M remoting/remoting_webapp_compile.gypi View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/webapp/build_template.gni View 2 chunks +5 lines, -1 line 0 comments Download
A + remoting/webapp/externs/qunit.js View 4 chunks +63 lines, -45 lines 0 comments Download
M remoting/webapp/files.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
James Hawkins
5 years, 6 months ago (2015-06-18 17:37:50 UTC) #2
garykac
lgtm
5 years, 6 months ago (2015-06-18 18:15:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196453003/40001
5 years, 6 months ago (2015-06-18 18:17:59 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-18 19:22:32 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ffbf1b6110ff79b0f9683a4f4acc67baf4900499 Cr-Commit-Position: refs/heads/master@{#335097}
5 years, 6 months ago (2015-06-18 19:23:26 UTC) #7
James Hawkins
5 years, 6 months ago (2015-06-18 20:33:39 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1183973010/ by jhawkins@chromium.org.

The reason for reverting is: Broke JSCompiler FYI bot.

Powered by Google App Engine
This is Rietveld 408576698