public/web/WebPlugin.h - Issue 1196433005: Change return type of the printPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebPlugin.h

Issue 1196433005: Change return type of the printPage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed printPage extra parameter changes from WebPluginContainerTest.cpp Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/web/WebPlugin.h

diff --git a/public/web/WebPlugin.h b/public/web/WebPlugin.h

index af3d0d0d1ea4a74608d63b78b1b9936edcd18599..9c35f9399b6723bd321bc184c88d291558988006 100644

--- a/public/web/WebPlugin.h

+++ b/public/web/WebPlugin.h

@@ -131,8 +131,6 @@ public:

// pages to be printed at these settings.

virtual int printBegin(const WebPrintParams& printParams) { return 0; }

- // TODO: Remove third parameter when both blink and chromium changes land for bug496765

- virtual void printPage(int pageNumber, WebCanvas* canvas, bool unused) { }

virtual void printPage(int pageNumber, WebCanvas* canvas) { }

// Ends the print operation.

« no previous file with comments | « Source/web/tests/WebPluginContainerTest.cpp ('k') | no next file » | no next file with comments »