Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196433005: Change return type of the printPage (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change return type of the printPage Last patch in the series of changing return type of the printPage method. This removes added extra function with three parameters. R=pdr BUG=496765 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197493

Patch Set 1 #

Patch Set 2 : Removed printPage extra parameter changes from WebPluginContainerTest.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebPlugin.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196433005/1
5 years, 6 months ago (2015-06-18 16:53:41 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/builds/11929)
5 years, 6 months ago (2015-06-18 17:09:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196433005/20001
5 years, 6 months ago (2015-06-19 10:59:32 UTC) #6
Habib Virji
This is the cleanup patch and removes extra parameter added.
5 years, 6 months ago (2015-06-19 11:12:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 12:02:33 UTC) #9
pdr.
LGTM! Thanks for this cleanup
5 years, 6 months ago (2015-06-19 18:47:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196433005/20001
5 years, 6 months ago (2015-06-19 18:47:34 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:51:56 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197493

Powered by Google App Engine
This is Rietveld 408576698