Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1196433002: Create and test source mapping for invocations. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index 395f45594ba95731a008995de43a63319e9d7615..f6fd6f43fe11733018652dadc88e982206c29c7e 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -29,7 +29,7 @@ typedef void IrBuilderCallback(Element element, ir.FunctionDefinition irNode);
/// This class is mainly there to correctly measure how long building the IR
/// takes.
class IrBuilderTask extends CompilerTask {
- final SourceInformationFactory sourceInformationFactory;
+ final SourceInformationStrategy sourceInformationStrategy;
String bailoutMessage = null;
@@ -37,7 +37,7 @@ class IrBuilderTask extends CompilerTask {
/// [ir.FunctionDefinition] node that has been built.
IrBuilderCallback builderCallback;
- IrBuilderTask(Compiler compiler, this.sourceInformationFactory,
+ IrBuilderTask(Compiler compiler, this.sourceInformationStrategy,
[this.builderCallback])
: super(compiler);
@@ -51,7 +51,7 @@ class IrBuilderTask extends CompilerTask {
element = element.implementation;
return compiler.withCurrentElement(element, () {
SourceInformationBuilder sourceInformationBuilder =
- sourceInformationFactory.forContext(element);
+ sourceInformationStrategy.createBuilderForContext(element);
IrBuilderVisitor builder =
new JsIrBuilderVisitor(
@@ -1004,7 +1004,8 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
}
return irBuilder.buildStaticFunctionInvocation(function, callStructure,
translateStaticArguments(arguments, function, callStructure),
- sourceInformation: sourceInformationBuilder.buildCall(node));
+ sourceInformation: sourceInformationBuilder.buildCall(
+ node, node.selector));
}
@override

Powered by Google App Engine
This is Rietveld 408576698