pkg/compiler/lib/src/native/ssa.dart - Issue 1196433002: Create and test source mapping for invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/native/ssa.dart

Issue 1196433002: Create and test source mapping for invocations. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/native/ssa.dart

diff --git a/pkg/compiler/lib/src/native/ssa.dart b/pkg/compiler/lib/src/native/ssa.dart

index 09f4e03d65d39364d49e03ae00a423e71983fe64..e622559339fa02276b66f05f5c4afd946c808c38 100644

--- a/pkg/compiler/lib/src/native/ssa.dart

+++ b/pkg/compiler/lib/src/native/ssa.dart

@@ -92,7 +92,10 @@ void handleSsaNative(SsaBuilder builder, Expression nativeBody) {

js.js.uncachedExpressionTemplate(nativeMethodCall),

backend.dynamicType,

inputs, effects: new SideEffects()));

- builder.close(new HReturn(builder.pop())).addSuccessor(builder.graph.exit);

+ // TODO(johnniwinther): Provide source information.

+ builder

+ .close(new HReturn(builder.pop(), null))

+ .addSuccessor(builder.graph.exit);

} else {

if (parameters.parameterCount != 0) {

compiler.internalError(nativeBody,