Issue 119643002: [ash] Create applist button's context menu in its ShelfItemDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119643002: [ash] Create applist button's context menu in its ShelfItemDelegate (Closed)

Created:
7 years ago by simonhong

Modified:
7 years ago

Reviewers:
James Cook

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, hyojun.im_lge.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[ash] Create applist button's context menu in its ShelfItemDelegate The context menu of applist button should create by its ShelfItemDelegate. R=jamescook@chromium.org BUG=NONE TEST=manual test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242083

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	ash/shelf/app_list_shelf_item_delegate.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	ash/shelf/shelf_view.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/119643002/1

7 years ago (2013-12-20 01:38:41 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108434

7 years ago (2013-12-20 10:24:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/119643002/1

7 years ago (2013-12-20 10:27:17 UTC) #5

Message was sent while issue was closed.

Change committed as 242083

Expand Messages | Collapse Messages