third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp - Issue 1196423003: Improve console log message for CORS failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 1196423003: Improve console log message for CORS failure (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('K') | « third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

index dd07563a5e11cf9cc61916fcb27957720a7dd178..14107531cc765d0cd152a733fbc6372676d11a36 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

@@ -257,7 +257,7 @@ bool ResourceFetcher::canAccessResource(Resource* resource, SecurityOrigin* sour

resource->setCORSFailed();

if (!forPreload && (logErrorsDecision == ShouldLogAccessControlErrors)) {

String resourceType = Resource::resourceTypeToString(resource->getType(), resource->options().initiatorInfo);

- context().addConsoleMessage(resourceType + " from origin '" + SecurityOrigin::create(url)->toString() + "' has been blocked from loading by Cross-Origin Resource Sharing policy: " + errorDescription);

+ context().addConsoleMessage("Access to " + resourceType + " at '" + url.getString() + "' from origin '" + SecurityOrigin::create(url)->toString() + "' has been blocked by CORS policy: " + errorDescription);

}

return false;

}