Issue 1196343002: Revert of DevTools: [Elements] F2 should commit changes in edit-as-html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1196343002: Revert of DevTools: [Elements] F2 should commit changes in edit-as-html (Closed)

Created:
5 years, 6 months ago by lushnikov

Modified:
5 years, 6 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of DevTools: [Elements] F2 should commit changes in edit-as-html (patchset #1 id:1 of https://codereview.chromium.org/1200833006/) Reason for revert: Revert as I forgot to address comments Original issue's description: > DevTools: [Elements] F2 should commit changes in edit-as-html > > BUG=493091 > R=pfeldman > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197588 TBR=pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493091 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197590

Patch Set 1 #

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -46 lines)			Patch
	M	Source/devtools/front_end/elements/ElementsTreeElement.js	View		2 chunks	+18 lines, -22 lines	0 comments	Download
	M	Source/devtools/front_end/ui/InplaceEditor.js	View		5 chunks	+12 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lushnikov

Created Revert of DevTools: [Elements] F2 should commit changes in edit-as-html

5 years, 6 months ago (2015-06-22 18:28:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196343002/1

5 years, 6 months ago (2015-06-22 18:28:33 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-22 18:29:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197590

Expand Messages | Collapse Messages