Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1196313003: Rename SkFontHost_none.cpp to SkFontMgr_empty_factory. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkFontHost_none.cpp to SkFontMgr_empty_factory. When the current function was added in https://skia.googlesource.com/skia/+/070da5edcb1c6e9b9507f06a5e2c270e1c1fd796%5E%21/#F3 the SkFontHost was still alive and well. Now that this file no longer contains any SkFontHost related code, rename the file for clarity and uniformity. Committed: https://skia.googlesource.com/skia/+/bd1fb49dd96d130aba5b2c17190b93b638469e86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
D src/ports/SkFontHost_none.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
A + src/ports/SkFontMgr_empty_factory.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196313003/1
5 years, 6 months ago (2015-06-22 22:33:00 UTC) #2
bungeman-skia
One more cleanup along the way to a better named set of font related files.
5 years, 6 months ago (2015-06-22 22:33:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 22:38:19 UTC) #6
reed1
lgtm
5 years, 6 months ago (2015-06-22 23:00:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196313003/1
5 years, 6 months ago (2015-06-23 14:17:41 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 14:18:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd1fb49dd96d130aba5b2c17190b93b638469e86

Powered by Google App Engine
This is Rietveld 408576698