Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1196253012: Make fast/text/justify-ideograph.html more reliable (Closed)

Created:
4 years, 10 months ago by eae
Modified:
4 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make fast/text/justify-ideograph.html more reliable Change fast/text/justify-ideograph.html to specify a line-height and use a web font declaration for Ahem to allow stand-alone inspection of test. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M LayoutTests/fast/text/justify-ideograph.html View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/text/justify-ideograph-expected.html View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eae
4 years, 10 months ago (2015-06-23 18:36:32 UTC) #2
leviw_travelin_and_unemployed
What does adding the line height get us? Were we failing to load Ahem properly ...
4 years, 10 months ago (2015-06-23 18:41:42 UTC) #3
eae
This test is awful and all failures I can see are due to the font ...
4 years, 10 months ago (2015-06-23 19:03:39 UTC) #4
leviw_travelin_and_unemployed
lgtm Seems fine as a speculative fix, but if the line height part of this ...
4 years, 10 months ago (2015-06-23 19:59:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196253012/1
4 years, 10 months ago (2015-06-23 20:02:22 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 20:07:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197671

Powered by Google App Engine
This is Rietveld 408576698