tools/telemetry/telemetry/web_perf/timeline_based_measurement.py - Issue 1196253011: [Telemetry] Adding Memory Timeline Metric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 1196253011: [Telemetry] Adding Memory Timeline Metric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: memory_timeline metric should use IterMemoryDumpEvents Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

index 252f2f9580a6add73b693f8e56d29bd432709887..fd4887a79b776a75a7dd44bce076beaf34a2f5cc 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

@@ -11,6 +11,7 @@ from telemetry.value import trace

from telemetry.web_perf.metrics import blob_timeline

from telemetry.web_perf.metrics import gpu_timeline

from telemetry.web_perf.metrics import layout

+from telemetry.web_perf.metrics import memory_timeline

from telemetry.web_perf.metrics import responsiveness_metric

from telemetry.web_perf.metrics import smoothness

from telemetry.web_perf import timeline_interaction_record as tir_module

@@ -39,7 +40,8 @@ def _GetAllTimelineBasedMetrics():

responsiveness_metric.ResponsivenessMetric(),

layout.LayoutMetric(),

gpu_timeline.GPUTimelineMetric(),

- blob_timeline.BlobTimelineMetric())

+ blob_timeline.BlobTimelineMetric(),

+ memory_timeline.MemoryTimelineMetric())

class InvalidInteractions(Exception):