Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py

Issue 1196253011: [Telemetry] Adding Memory Timeline Metric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: memory_timeline metric should use IterMemoryDumpEvents Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
diff --git a/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py b/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
index acd8b6610f15804fc0b3f2644832adc0f0ab80e9..db3ca648a31230596b14fd8cbb6e47231ca60323 100644
--- a/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
+++ b/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
@@ -1017,3 +1017,49 @@ class TraceEventTimelineImporterTest(unittest.TestCase):
trace_data = trace_data_module.TraceData(events)
m = timeline_model.TimelineModel(trace_data)
self.assertEqual(0, len(m.flow_events))
+
+ def testImportMemoryDumpEvents(self):
+ events = [
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 52, 'ts': 123,
+ 'id': '1234ABCD'},
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 54, 'ts': 134,
+ 'id': '1234ABCD'},
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 52, 'ts': 245,
+ 'id': '1234ABDF'},
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 54, 'ts': 256,
+ 'id': '1234ABDF'},
+ ]
+
+ expected = [['1234ABCD', 0, 11], ['1234ABDF', 122, 11]]
+ trace_data = trace_data_module.TraceData(events)
+ m = timeline_model.TimelineModel(trace_data)
+ memory_dump_events = list(m.IterMemoryDumpEvents())
+ self.assertEqual(len(expected), len(memory_dump_events))
+ for event, test_values in zip(memory_dump_events, expected):
+ dump_id, start, duration = test_values
+ self.assertEquals(dump_id, event.dump_id)
+ self.assertAlmostEqual(start / 1000.0, event.start)
+ self.assertAlmostEqual(duration / 1000.0, event.duration)
+
+ def testImportOutOfOrderMemoryDumpEvents(self):
+ events = [
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 52, 'ts': 245,
+ 'id': '1234ABDF'},
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 54, 'ts': 134,
+ 'id': '1234ABCD'},
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 54, 'ts': 256,
+ 'id': '1234ABDF'},
+ {'name': 'a', 'cat': 'b', 'ph': 'v', 'pid': 52, 'ts': 123,
+ 'id': '1234ABCD'},
+ ]
+
+ expected = [['1234ABCD', 0, 11], ['1234ABDF', 122, 11]]
+ trace_data = trace_data_module.TraceData(events)
+ m = timeline_model.TimelineModel(trace_data)
+ memory_dump_events = list(m.IterMemoryDumpEvents())
+ self.assertEqual(len(expected), len(memory_dump_events))
+ for event, test_values in zip(memory_dump_events, expected):
+ dump_id, start, duration = test_values
+ self.assertEquals(dump_id, event.dump_id)
+ self.assertAlmostEqual(start / 1000.0, event.start)
+ self.assertAlmostEqual(duration / 1000.0, event.duration)

Powered by Google App Engine
This is Rietveld 408576698