Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196253002: [android] Merge gyp configurations. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[android] Merge gyp configurations. The merge makes it possible to reuse variables from the android configuration in standalone.gypi. BUG=chromium:502176 LOG=n Committed: https://crrev.com/2197ef2aaf544ae0806870073e3d20307dce9d9a Cr-Commit-Position: refs/heads/master@{#29189}

Patch Set 1 #

Patch Set 2 : Landmine #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -305 lines) Patch
M Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M Makefile.android View 2 chunks +7 lines, -7 lines 0 comments Download
D build/android.gypi View 1 chunk +0 lines, -296 lines 0 comments Download
M build/get_landmines.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/standalone.gypi View 2 chunks +265 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196253002/20001
5 years, 6 months ago (2015-06-22 12:30:28 UTC) #2
Michael Achenbach
PTAL https://codereview.chromium.org/1196253002/diff/20001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1196253002/diff/20001/build/standalone.gypi#newcode208 build/standalone.gypi:208: }], 1:1 from android.gypi https://codereview.chromium.org/1196253002/diff/20001/build/standalone.gypi#newcode745 build/standalone.gypi:745: }], # ...
5 years, 6 months ago (2015-06-22 12:31:32 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-22 12:33:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196253002/20001
5 years, 6 months ago (2015-06-22 12:40:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 13:17:22 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 13:17:30 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2197ef2aaf544ae0806870073e3d20307dce9d9a
Cr-Commit-Position: refs/heads/master@{#29189}

Powered by Google App Engine
This is Rietveld 408576698