Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3461)

Unified Diff: chrome/browser/ui/webui/voice_search_ui.cc

Issue 1196243003: chrome://voicesearch: Change some labels to clarify their meaning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change strings per pkasting review. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/voice_search_ui.cc
diff --git a/chrome/browser/ui/webui/voice_search_ui.cc b/chrome/browser/ui/webui/voice_search_ui.cc
index 9f45d062f4d0575b25445bba90bc471e1406f4f0..a6851b317d269d4a269e542456033d116d362f4c 100644
--- a/chrome/browser/ui/webui/voice_search_ui.cc
+++ b/chrome/browser/ui/webui/voice_search_ui.cc
@@ -271,7 +271,7 @@ class VoiceSearchDomHandler : public WebUIMessageHandler {
HotwordService* hotword_service =
HotwordServiceFactory::GetForProfile(profile_);
- AddPair(list, "Microphone",
+ AddPair(list, "Microphone Present",
hotword_service && hotword_service->microphone_available() ? "Yes"
: "No");
@@ -303,6 +303,13 @@ class VoiceSearchDomHandler : public WebUIMessageHandler {
// Adds information specific to the hotword configuration to the list.
void AddHotwordInfo(base::ListValue* list) {
+ HotwordService* hotword_service =
+ HotwordServiceFactory::GetForProfile(profile_);
+ std::string hotword_allowed = "No";
+ if (hotword_service && hotword_service->IsHotwordAllowed())
+ hotword_allowed = "Yes";
+ AddPair(list, "Hotword Module Installable", hotword_allowed);
+
std::string search_enabled = "No";
if (profile_->GetPrefs()->GetBoolean(prefs::kHotwordSearchEnabled))
search_enabled = "Yes";
@@ -314,8 +321,6 @@ class VoiceSearchDomHandler : public WebUIMessageHandler {
AddPair(list, "Always-on Hotword Search Enabled", always_on_search_enabled);
std::string audio_logging_enabled = "No";
- HotwordService* hotword_service =
- HotwordServiceFactory::GetForProfile(profile_);
if (hotword_service && hotword_service->IsOptedIntoAudioLogging())
audio_logging_enabled = "Yes";
AddPair(list, "Hotword Audio Logging Enabled", audio_logging_enabled);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698