Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 1196213004: [turbofan] Add CodeFactory::Instanceof helper. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add CodeFactory::Instanceof helper. R=mvstanton@chromium.org TEST=cctest/test-run-jsops/BinopInstanceOf Committed: https://crrev.com/86594b7da24cce04f0801d8033029414433fb4ed Cr-Commit-Position: refs/heads/master@{#29187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-22 11:52:56 UTC) #1
mvstanton
Very nice, LGTM.
5 years, 6 months ago (2015-06-22 11:54:08 UTC) #2
mvstanton
Very nice, LGTM.
5 years, 6 months ago (2015-06-22 11:54:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196213004/1
5 years, 6 months ago (2015-06-22 12:07:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 12:16:01 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 12:16:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86594b7da24cce04f0801d8033029414433fb4ed
Cr-Commit-Position: refs/heads/master@{#29187}

Powered by Google App Engine
This is Rietveld 408576698