Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 11962050: Fix the comment of PPB_MessageLoop.PostWork() (Closed)

Created:
7 years, 11 months ago by yzshen1
Modified:
7 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Fix the comment of PPB_MessageLoop.PostWork() The current comment says that PostWork() returns PP_OK_COMPLETIONPENDING if successful. This CL changes it to PP_OK. TEST=None BUG=170777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M ppapi/api/ppb_message_loop.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/c/ppb_message_loop.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/cpp/message_loop.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, David. Would you please take a look? Thanks!
7 years, 11 months ago (2013-01-17 22:19:39 UTC) #1
dmichael (off chromium)
lgtm, thanks!
7 years, 11 months ago (2013-01-17 22:23:48 UTC) #2
yzshen1
On 2013/01/17 22:23:48, dmichael wrote: > lgtm, thanks! Thanks! I am also sending a mail ...
7 years, 11 months ago (2013-01-17 22:25:17 UTC) #3
dmichael (off chromium)
On Thu, Jan 17, 2013 at 3:25 PM, <yzshen@chromium.org> wrote: > On 2013/01/17 22:23:48, dmichael ...
7 years, 11 months ago (2013-01-17 22:27:44 UTC) #4
yzshen1
> Good idea. FWIW I'm not overly concerned; it's always worked this way, and > ...
7 years, 11 months ago (2013-01-17 22:33:42 UTC) #5
yzshen1
7 years, 11 months ago (2013-01-17 23:13:28 UTC) #6
Committed as r177519.

Powered by Google App Engine
This is Rietveld 408576698