chromeos/network/onc/onc_certificate_importer.cc - Issue 11962048: This adds Cellular to the Shill to ONC translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_certificate_importer.cc

Issue 11962048: This adds Cellular to the Shill to ONC translation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix some semantics Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_certificate_importer.cc

diff --git a/chromeos/network/onc/onc_certificate_importer.cc b/chromeos/network/onc/onc_certificate_importer.cc

index 451c6d950c422e2113688ec2722b0878178f879d..2caf2735a86501afd2d715cd210c91d03d2065f9 100644

--- a/chromeos/network/onc/onc_certificate_importer.cc

+++ b/chromeos/network/onc/onc_certificate_importer.cc

@@ -74,7 +74,7 @@ bool CertificateImporter::ParseAndStoreCertificate(

const base::DictionaryValue& certificate) {

// Get out the attributes of the given certificate.

std::string guid;

- if (!certificate.GetString(kGUID, &guid) || guid.empty()) {

+ if (!certificate.GetString(network_config::kGUID, &guid) || guid.empty()) {

pneubeck (no reviews) 2013/01/18 10:27:41 (onc::)kGUID, see comment in onc_constant.h

ONC_LOG_ERROR("Certificate missing GUID identifier");

return false;

}