This adds Cellular to the Shill to ONC translation.

chromeos/network/onc/onc_translation_tables.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_ONC_ONC_TRANSLATION_TABLES_H_
 #define CHROMEOS_NETWORK_ONC_ONC_TRANSLATION_TABLES_H_
 
+#include <string>
+
+#include "chromeos/chromeos_export.h"
+
 namespace chromeos {
 namespace onc {
 
 struct StringTranslationEntry {
   const char* onc_value;
   const char* shill_value;
 };
 
 // These tables contain the mapping from ONC strings to Shill strings.
 // These are NULL-terminated arrays.
-extern const StringTranslationEntry kNetworkTypeTable[];
-extern const StringTranslationEntry kVPNTypeTable[];
-extern const StringTranslationEntry kWiFiSecurityTable[];
-extern const StringTranslationEntry kEAPOuterTable[];
-extern const StringTranslationEntry kEAP_PEAP_InnerTable[];
-extern const StringTranslationEntry kEAP_TTLS_InnerTable[];
+CHROMEOS_EXPORT extern const StringTranslationEntry kNetworkTypeTable[];

[pneubeck (no reviews), 2013/01/18 10:27:41]

What for would we export these?

The idea was to translate parts of ONC by using (e.g. for the WiFi sub-object):
TranslateShillServiceToONCPart(shill_dict, &kWiFiSignature);
TranslateONCObjectToShill(onc_wifi, &kWiFiSignature);

[Greg Spencer (Chromium), 2013/01/18 22:27:44]

I needed to have these, and the functions below because the JavaScript is
passing in an ONC "Type" for the type of networks it wants to get back from
"getVisibleNetworks", and so I need to translate the Shill type into an ONC type
in order to filter it properly.

See line 195 here for an example usage: 
https://codereview.chromium.org/11975015
diff/27001/chrome/browser/chromeos/extensions/networking_private_api.cc

For this I need to translate the value and not the entire object.

I could rearrange the code in that example to translate the Shill service object
first and then see if it's the right type, but that seems inefficient, since I
can avoid the entire translation if I just look at the type.

[pneubeck (no reviews), 2013/01/21 08:32:18]

The nice thing is, that the signatures work not only for dictionaries but also
for simple values.
So, no need to change a lot:

Just add a new OncValueSignature for the relevant value to onc_signature.cc and
.h (e.g. instead of kStringSignature).
Afterwards you can apply the TranslateONCObjectToShill /
TranslateShillServiceToONCPart functions with that signature to the single value
/ or extract from a Shill dict only that value.

+CHROMEOS_EXPORT extern const StringTranslationEntry kVPNTypeTable[];
+CHROMEOS_EXPORT extern const StringTranslationEntry kWiFiSecurityTable[];
+CHROMEOS_EXPORT extern const StringTranslationEntry kEAPOuterTable[];
+CHROMEOS_EXPORT extern const StringTranslationEntry kEAP_PEAP_InnerTable[];
+CHROMEOS_EXPORT extern const StringTranslationEntry kEAP_TTLS_InnerTable[];
+
+// Translate individual strings to Shill using the above tables.
+CHROMEOS_EXPORT bool TranslateStringToShill(
+    const StringTranslationEntry table[],
+    const std::string& onc_value,
+    std::string* shill_value);
+
+// Translate individual strings to ONC using the above tables.
+CHROMEOS_EXPORT bool TranslateStringToONC(const StringTranslationEntry table[],
+                                          const std::string& shill_value,
+                                          std::string* onc_value);
 
 }  // namespace onc
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_ONC_ONC_TRANSLATION_TABLES_H_