Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11962043: Move webui resources from chrome\browser\resources\shared to ui\webui\resources. (Closed)

Created:
7 years, 11 months ago by jam
Modified:
7 years, 10 months ago
Reviewers:
Dan Beam, Jói
CC:
chromium-reviews, asanka, dbeam+watch-ntp_chromium.org, nkostylev+watch_chromium.org, dcheng, rginda+watch_chromium.org, stevenjb+watch_chromium.org, joi+watch-content_chromium.org, benjhayden+dwatch_chromium.org, Patrick Dubroy, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-options_chromium.org, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org, oshima+watch_chromium.org, tfarina, Aaron Boodman, estade+watch_chromium.org
Visibility:
Public.

Description

Move webui resources from chrome\browser\resources\shared to ui\webui\resources. BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -17885 lines) Patch
M build/ios/grit_whitelist.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/about_sys.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/image_burner.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/network_dropdown.css View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/offline_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/main_scripts.js View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/main.html View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/browser/resources/cloud_print/cloud_print_setup_done.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/downloads/downloads.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/downloads/downloads.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/action_choice.html View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/gallery.html View 2 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/resources/file_manager/js/action_choice_scripts.js View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/js/main_scripts.js View 1 chunk +29 lines, -29 lines 0 comments Download
M chrome/browser/resources/file_manager/js/media/video_player_scripts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery_scripts.js View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/photo_import_scripts.js View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 2 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/resources/file_manager/photo_import.html View 2 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/resources/file_manager/video_player.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/flags_warning.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gpu_internals/timeline_test.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/history/history.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/incognito_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/managed_mode_block_interstitial.html View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/media_internals/disjoint_range_set_test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 2 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp_android/new_tab.html View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp_search/new_tab.html View 2 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/resources/options/browser_options.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugins.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/data/measurement_system_unittest.gtestjs View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/quota_internals/main.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/safe_browsing/malware_block_v2.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/safe_browsing/malware_block_v2.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/safe_browsing_multiple_threat_block.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/shared/css/alert_overlay.css View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/shared/css/bubble.css View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/resources/shared/css/bubble_button.css View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/resources/shared/css/chrome_shared.css View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/resources/shared/css/chromeos/ui_account_tweaks.css View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/resources/shared/css/dialogs.css View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/resources/shared/css/expandable_bubble.css View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/resources/shared/css/list.css View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/resources/shared/css/menu.css View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/resources/shared/css/menu_button.css View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/shared/css/overlay.css View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/resources/shared/css/spinner.css View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/resources/shared/css/table.css View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/resources/shared/css/tabs.css View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/resources/shared/css/throbber.css View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/resources/shared/css/trash.css View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/resources/shared/css/tree.css View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/browser/resources/shared/css/tree.css.js View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/resources/shared/css/widgets.css View 1 chunk +0 lines, -309 lines 0 comments Download
D chrome/browser/resources/shared/html/alert_overlay.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/shared/html/trash.html View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/shared/images/2x/check.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/checkbox_black.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/checkbox_white.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/disabled_select.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/downloads_section.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/gear.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/help.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/otr_icon_standalone.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/select.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/x.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/x-hover.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/2x/x-pressed.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/check.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/checkbox_black.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/checkbox_white.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/clouds.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/detected_sd.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/detected_usb.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/disabled_select.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/downloads_section.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/gear.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/google-transparent.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/help.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/icon_checkmark.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/icon_file.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/icon_warning.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/insert.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/laptop-64.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/minus.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/otr_icon_standalone.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/phishing_icon.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/phone-64.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/plus.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/select.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/spinner.svg View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/resources/shared/images/star_small.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/success.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/tablet-64.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/throbber.svg View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/shared/images/trash.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/x.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/x-hover.png View Binary file 0 comments Download
D chrome/browser/resources/shared/images/x-pressed.png View Binary file 0 comments Download
D chrome/browser/resources/shared/js/chromeos/ui_account_tweaks.js View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/resources/shared/js/cr.js View 1 chunk +0 lines, -378 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/event_target.js View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/event_target_test.html View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/link_controller.js View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/link_controller_test.html View 1 chunk +0 lines, -353 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/promise.js View 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/promise_test.html View 1 chunk +0 lines, -250 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui.js View 1 chunk +0 lines, -206 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/alert_overlay.js View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/array_data_model.js View 1 chunk +0 lines, -413 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/array_data_model_test.html View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/autocomplete_list.js View 1 chunk +0 lines, -241 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/bubble.js View 1 chunk +0 lines, -514 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/bubble_button.js View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/card_slider.js View 1 chunk +0 lines, -680 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/command.js View 1 chunk +0 lines, -311 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/context_menu_button.js View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js View 1 chunk +0 lines, -262 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/dialogs.js View 1 chunk +0 lines, -302 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/drag_wrapper.js View 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/expandable_bubble.js View 1 chunk +0 lines, -303 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/focus_manager.js View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/focus_outline_manager.js View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/grid.js View 1 chunk +0 lines, -425 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/grid_test.html View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list.js View 1 chunk +0 lines, -1277 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_item.js View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js View 1 chunk +0 lines, -286 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_selection_model.js View 1 chunk +0 lines, -347 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_selection_model_test.html View 1 chunk +0 lines, -216 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_selection_model_test_util.js View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/list_single_selection_model_test.html View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/menu.js View 1 chunk +0 lines, -248 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/menu_button.js View 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/menu_item.js View 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/overlay.js View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/position_util.js View 1 chunk +0 lines, -243 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/position_util_test.html View 1 chunk +0 lines, -310 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/repeating_button.js View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/splitter.js View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/table.js View 1 chunk +0 lines, -379 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/table/table_column.js View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/table/table_column_model.js View 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/table/table_header.js View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/table/table_list.js View 1 chunk +0 lines, -198 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/table/table_splitter.js View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/tabs.js View 1 chunk +0 lines, -220 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/touch_handler.js View 1 chunk +0 lines, -875 lines 0 comments Download
D chrome/browser/resources/shared/js/cr/ui/tree.js View 1 chunk +0 lines, -676 lines 0 comments Download
D chrome/browser/resources/shared/js/cr_test.html View 1 chunk +0 lines, -289 lines 0 comments Download
D chrome/browser/resources/shared/js/event_tracker.js View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/resources/shared/js/i18n_process.js View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/resources/shared/js/i18n_template.js View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/resources/shared/js/i18n_template2.js View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/shared/js/i18n_template_no_process.js View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/resources/shared/js/jstemplate_compiled.js View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/resources/shared/js/load_time_data.js View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/resources/shared/js/local_strings.js View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/resources/shared/js/local_strings_test.html View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/resources/shared/js/media_common.js View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/resources/shared/js/parse_html_subset.js View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/resources/shared/js/parse_html_subset_test.html View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/resources/shared/js/util.js View 1 chunk +0 lines, -321 lines 0 comments Download
D chrome/browser/resources/shared_resources.grd View 1 chunk +0 lines, -211 lines 0 comments Download
M chrome/browser/resources/sync_internals/sync_node_browser.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_promo/sync_promo.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/sync_promo/sync_promo.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/shared_resources_data_source.cc View 2 chunks +5 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/common_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/jstemplate_builder.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/tools/check_grd_for_unused_strings.py View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A content/public/browser/web_ui_data_source.h View 1 chunk +73 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_resources.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
A + ui/webui/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M + ui/webui/resources/css/bubble.css View 1 chunk +6 lines, -10 lines 0 comments Download
M + ui/webui/resources/css/expandable_bubble.css View 1 chunk +6 lines, -10 lines 0 comments Download
M + ui/webui/resources/css/tree.css View 2 chunks +8 lines, -8 lines 0 comments Download
M + ui/webui/resources/js/jstemplate_compiled.js View 1 chunk +1 line, -1 line 0 comments Download
A + ui/webui/resources/webui_resources.grd View 1 chunk +172 lines, -168 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
7 years, 11 months ago (2013-01-17 17:27:17 UTC) #1
jam
btw i've taken out content/content_browser.gypi & content/public/browser/web_ui_data_source.h locally, these were part of another cl
7 years, 11 months ago (2013-01-17 17:37:23 UTC) #2
Jói
LGTM once those two files are removed.
7 years, 11 months ago (2013-01-17 17:43:48 UTC) #3
Dan Beam
7 years, 10 months ago (2013-02-14 23:18:52 UTC) #4
Message was sent while issue was closed. 
FYI: PRESUBMIT checks that were run on chrome/browser/resources aren't running
in these files' new locations.

Powered by Google App Engine
This is Rietveld 408576698