Issue 11962002: Merge 175452

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11962002: Merge 175452 (Closed)

Created:
7 years, 11 months ago by oshima

Modified:
7 years, 11 months ago

Reviewers:
sabercrombie1

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/branches/1364/src/

Visibility:
Public.

Merge 175452 > MessagePumpAuraX11: Make root_window_dispatchers_ an ObserverList. > > Using std::vector caused crashes in cases where a Dispatch call resulted in a Dispatcher being added and that addition provoked reallocation of the vector's storage. This resulted in a bad iterator dereference in the dispatch loop. > > BUG=chrome-os-partner:15544 > TEST=Monitor unplugging/power removal still works. The crash case no longer crashes. > > Review URL: https://chromiumcodereview.appspot.com/11593015 TBR=sabercrombie@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177007

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -20 lines)			Patch
	M	base/message_pump_aurax11.h	View		3 chunks	+9 lines, -6 lines	0 comments	Download
	M	base/message_pump_aurax11.cc	View		2 chunks	+4 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.