Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: src/x64/builtins-x64.cc

Issue 1196193014: Do not add extra argument for new.target (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment added Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x64/builtins-x64.cc
diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc
index 2d4421d7e12d811ab0730a6be325ffc671282bb8..0de2e6cd2546b2ed4b870c9e6e31e56f5b0e61dc 100644
--- a/src/x64/builtins-x64.cc
+++ b/src/x64/builtins-x64.cc
@@ -527,8 +527,6 @@ void Builtins::Generate_JSConstructStubForDerived(MacroAssembler* masm) {
__ decp(rcx);
__ j(greater_equal, &loop);
- __ incp(rax); // Pushed new.target.
-
// Handle step in.
Label skip_step_in;
ExternalReference debug_step_in_fp =
@@ -553,8 +551,9 @@ void Builtins::Generate_JSConstructStubForDerived(MacroAssembler* masm) {
// Restore context from the frame.
__ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
- __ movp(rbx, Operand(rsp, 0)); // Get arguments count.
- } // Leave construct frame.
+ // Get arguments count, skipping over new.target.
+ __ movp(rbx, Operand(rsp, kPointerSize)); // Get arguments count.
+ } // Leave construct frame.
// Remove caller arguments from the stack and return.
__ PopReturnAddressTo(rcx);
« src/arm/full-codegen-arm.cc ('K') | « src/objects.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698