Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: src/code-stubs.h

Issue 1196193014: Do not add extra argument for new.target (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment added Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 515f2e578e613470e9a228826df201f7bba6d116..e6a3e3a2b9feb48a658b86338e8496c5a8d7959e 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1785,13 +1785,8 @@ class ArgumentsAccessStub: public PlatformCodeStub {
NEW_STRICT
};
- enum HasNewTarget { NO_NEW_TARGET, HAS_NEW_TARGET };
-
- ArgumentsAccessStub(Isolate* isolate, Type type,
- HasNewTarget has_new_target = NO_NEW_TARGET)
- : PlatformCodeStub(isolate) {
- minor_key_ =
- TypeBits::encode(type) | HasNewTargetBits::encode(has_new_target);
+ ArgumentsAccessStub(Isolate* isolate, Type type) : PlatformCodeStub(isolate) {
+ minor_key_ = TypeBits::encode(type);
}
CallInterfaceDescriptor GetCallInterfaceDescriptor() override {
@@ -1803,9 +1798,6 @@ class ArgumentsAccessStub: public PlatformCodeStub {
private:
Type type() const { return TypeBits::decode(minor_key_); }
- bool has_new_target() const {
- return HasNewTargetBits::decode(minor_key_) == HAS_NEW_TARGET;
- }
void GenerateReadElement(MacroAssembler* masm);
void GenerateNewStrict(MacroAssembler* masm);
@@ -1815,7 +1807,6 @@ class ArgumentsAccessStub: public PlatformCodeStub {
void PrintName(std::ostream& os) const override; // NOLINT
class TypeBits : public BitField<Type, 0, 2> {};
- class HasNewTargetBits : public BitField<HasNewTarget, 2, 1> {};
DEFINE_PLATFORM_CODE_STUB(ArgumentsAccess, PlatformCodeStub);
};

Powered by Google App Engine
This is Rietveld 408576698