Allow preload scanners to be disabled by Settings.

Source/core/html/parser/HTMLPreloadScannerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/html/parser/HTMLPreloadScanner.h"
 
 #include "core/MediaTypeNames.h"
 #include "core/css/MediaValuesCached.h"
 #include "core/fetch/ClientHintsPreferences.h"
 #include "core/frame/Settings.h"
 #include "core/html/CrossOriginAttribute.h"
 #include "core/html/parser/HTMLParserOptions.h"
 #include "core/html/parser/HTMLResourcePreloader.h"
 #include "core/testing/DummyPageHolder.h"
 #include <gtest/gtest.h>
 
 namespace blink {
 
-typedef struct {
+struct TestCase {
     const char* baseURL;
     const char* inputHTML;
-    const char* preloadedURL;
+    const char* preloadedURL; // Or nullptr if no preload is expected.
     const char* outputBaseURL;
     Resource::Type type;
     int resourceWidth;
     ClientHintsPreferences preferences;
-} TestCase;
+};
 
-typedef struct {
+struct PreconnectTestCase {
     const char* baseURL;
     const char* inputHTML;
     const char* preconnectedHost;
     CrossOriginAttributeValue crossOrigin;
-} PreconnectTestCase;
+};
 
 class MockHTMLResourcePreloader : public ResourcePreloader {
 public:
-    void preloadRequestVerification(Resource::Type type, const String& url, const String& baseURL, int width, const ClientHintsPreferences& preferences)
+    void preloadRequestVerification(Resource::Type type, const char* url, const char* baseURL, int width, const ClientHintsPreferences& preferences)
     {
+        if (!url) {
+            EXPECT_FALSE(m_preloadRequest);
+            return;
+        }
         EXPECT_FALSE(m_preloadRequest->isPreconnect());
         EXPECT_EQ(type, m_preloadRequest->resourceType());
-        EXPECT_STREQ(url.ascii().data(), m_preloadRequest->resourceURL().ascii().data());
-        EXPECT_STREQ(baseURL.ascii().data(), m_preloadRequest->baseURL().string().ascii().data());
+        EXPECT_STREQ(url, m_preloadRequest->resourceURL().ascii().data());
+        EXPECT_STREQ(baseURL, m_preloadRequest->baseURL().string().ascii().data());
         EXPECT_EQ(width, m_preloadRequest->resourceWidth());
         EXPECT_EQ(preferences.shouldSendDPR(), m_preloadRequest->preferences().shouldSendDPR());
         EXPECT_EQ(preferences.shouldSendResourceWidth(), m_preloadRequest->preferences().shouldSendResourceWidth());
         EXPECT_EQ(preferences.shouldSendViewportWidth(), m_preloadRequest->preferences().shouldSendViewportWidth());
     }
 
     void preconnectRequestVerification(const String& host, CrossOriginAttributeValue crossOrigin)
     {
         if (!host.isNull()) {
             EXPECT_TRUE(m_preloadRequest->isPreconnect());
             EXPECT_STREQ(m_preloadRequest->resourceURL().ascii().data(), host.ascii().data());
             EXPECT_EQ(m_preloadRequest->isCORS(), crossOrigin != CrossOriginAttributeNotSet);
             EXPECT_EQ(m_preloadRequest->isAllowCredentials(), crossOrigin == CrossOriginAttributeUseCredentials);
         }
     }
 
 protected:
     void preload(PassOwnPtr<PreloadRequest> preloadRequest) override
     {
         m_preloadRequest = preloadRequest;
     }
 
 private:
     OwnPtr<PreloadRequest> m_preloadRequest;
 };
 
 class HTMLPreloadScannerTest : public testing::Test {
 protected:
+    enum ViewportState {
+        ViewportEnabled,
+        ViewportDisabled,
+    };
+
+    enum PreloadState {
+        PreloadEnabled,
+        PreloadDisabled,
+    };
+
     HTMLPreloadScannerTest()
         : m_dummyPageHolder(DummyPageHolder::create())
     {
     }
 
     PassRefPtr<MediaValues> createMediaValues()
     {
         MediaValuesCached::MediaValuesCachedData data;
         data.viewportWidth = 500;
         data.viewportHeight = 600;
         data.deviceWidth = 500;
         data.deviceHeight = 500;
         data.devicePixelRatio = 2.0;
         data.colorBitsPerComponent = 24;
         data.monochromeBitsPerComponent = 0;
         data.primaryPointerType = PointerTypeFine;
         data.defaultFontSize = 16;
         data.threeDEnabled = true;
         data.mediaType = MediaTypeNames::screen;
         data.strictMode = true;
         data.displayMode = WebDisplayModeBrowser;
         return MediaValuesCached::create(data);
     }
 
-    void runSetUp(bool viewportEnabled)
+    void runSetUp(ViewportState viewportState, PreloadState preloadState = PreloadEnabled)
     {
         HTMLParserOptions options(&m_dummyPageHolder->document());
         KURL documentURL(ParsedURLString, "http://whatever.test/");
-        m_dummyPageHolder->document().settings()->setViewportEnabled(viewportEnabled);
-        m_dummyPageHolder->document().settings()->setViewportMetaEnabled(viewportEnabled);
+        m_dummyPageHolder->document().settings()->setViewportEnabled(viewportState == ViewportEnabled);
+        m_dummyPageHolder->document().settings()->setViewportMetaEnabled(viewportState == ViewportEnabled);
+        m_dummyPageHolder->document().settings()->setDoHtmlPreloadScanning(preloadState == PreloadEnabled);
         m_scanner = HTMLPreloadScanner::create(options, documentURL, CachedDocumentParameters::create(&m_dummyPageHolder->document(), createMediaValues()));
     }
 
     void SetUp() override
     {
-        runSetUp(true);
+        runSetUp(ViewportEnabled);
     }
 
     void test(TestCase testCase)
     {
         MockHTMLResourcePreloader preloader;
         KURL baseURL(ParsedURLString, testCase.baseURL);
         m_scanner->appendToEnd(String(testCase.inputHTML));
         m_scanner->scan(&preloader, baseURL);
 
         preloader.preloadRequestVerification(testCase.type, testCase.preloadedURL, testCase.outputBaseURL, testCase.resourceWidth, testCase.preferences);
@@ skipping 62 matching lines @@
         {"http://example.test", "<img srcset='bla2.gif 160w, bla3.gif 250w, bla4.gif 500w' src='bla.gif' sizes='50vw'>", "bla2.gif", "http://example.test/", Resource::Image, 80},
         {"http://example.test", "<img srcset='bla2.gif 160w, bla3.gif 250w, bla4.gif 500w' sizes='50vw' src='bla.gif'>", "bla2.gif", "http://example.test/", Resource::Image, 80},
     };
 
     for (const auto& testCase : testCases)
         test(testCase);
 }
 
 TEST_F(HTMLPreloadScannerTest, testImagesWithViewportDisabled)
 {
-    runSetUp(false);
+    runSetUp(ViewportDisabled);
     TestCase testCases[] = {
         {"http://example.test", "<meta name=viewport content='width=160'><img src='bla.gif'>", "bla.gif", "http://example.test/", Resource::Image, 0},
         {"http://example.test", "<img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0},
         {"http://example.test", "<img sizes='50vw' src='bla.gif'>", "bla.gif", "http://example.test/", Resource::Image, 250},
         {"http://example.test", "<img sizes='50vw' src='bla.gif' srcset='bla2.gif 1x'>", "bla2.gif", "http://example.test/", Resource::Image, 250},
         {"http://example.test", "<img sizes='50vw' src='bla.gif' srcset='bla2.gif 0.5x'>", "bla.gif", "http://example.test/", Resource::Image, 250},
         {"http://example.test", "<img sizes='50vw' src='bla.gif' srcset='bla2.gif 100w'>", "bla2.gif", "http://example.test/", Resource::Image, 250},
         {"http://example.test", "<img sizes='50vw' src='bla.gif' srcset='bla2.gif 100w, bla3.gif 250w'>", "bla3.gif", "http://example.test/", Resource::Image, 250},
         {"http://example.test", "<img sizes='50vw' src='bla.gif' srcset='bla2.gif 100w, bla3.gif 250w, bla4.gif 500w'>", "bla4.gif", "http://example.test/", Resource::Image, 250},
         {"http://example.test", "<img src='bla.gif' srcset='bla2.gif 100w, bla3.gif 250w, bla4.gif 500w' sizes='50vw'>", "bla4.gif", "http://example.test/", Resource::Image, 250},
@@ skipping 37 matching lines @@
         {"http://example.test", "<meta http-equiv='accept-ch' content='dpr \t'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, dpr},
         {"http://example.test", "<meta http-equiv='accept-ch' content='bla,dpr \t'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, dpr},
         {"http://example.test", "<meta http-equiv='accept-ch' content='  width  '><img sizes='100vw' srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 500, resourceWidth},
         {"http://example.test", "<meta http-equiv='accept-ch' content='  width  , wutever'><img sizes='300px' srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 300, resourceWidth},
         {"http://example.test", "<meta http-equiv='accept-ch' content='  viewport-width  '><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, viewportWidth},
         {"http://example.test", "<meta http-equiv='accept-ch' content='  viewport-width  , wutever'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, viewportWidth},
         {"http://example.test", "<meta http-equiv='accept-ch' content='  viewport-width  ,width, wutever, dpr \t'><img sizes='90vw' srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 450, all},
     };
 
     for (const auto& testCase : testCases) {
-        runSetUp(false);
+        runSetUp(ViewportDisabled);
         test(testCase);
     }
 }
 
 TEST_F(HTMLPreloadScannerTest, testPreconnect)
 {
     PreconnectTestCase testCases[] = {
         {"http://example.test", "<link rel=preconnect href=http://example2.test>", "http://example2.test", CrossOriginAttributeNotSet},
         {"http://example.test", "<link rel=preconnect href=http://example2.test crossorigin=anonymous>", "http://example2.test", CrossOriginAttributeAnonymous},
         {"http://example.test", "<link rel=preconnect href=http://example2.test crossorigin='use-credentials'>", "http://example2.test", CrossOriginAttributeUseCredentials},
         {"http://example.test", "<link rel=preconnected href=http://example2.test crossorigin='use-credentials'>", nullptr, CrossOriginAttributeNotSet},
         {"http://example.test", "<link rel=preconnect href=ws://example2.test crossorigin='use-credentials'>", nullptr, CrossOriginAttributeNotSet},
     };
 
     for (const auto& testCase : testCases)
         test(testCase);
 }
 
+TEST_F(HTMLPreloadScannerTest, testDisables)
+{
+    runSetUp(ViewportEnabled, PreloadDisabled);
+
+    TestCase testCases[] = {
+        {"http://example.test", "<img src='bla.gif'>"},
+    };
+
+    for (const auto& testCase : testCases)
+        test(testCase);
+}
+
 } // namespace blink