Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 1196193005: Allow preload scanners to be disabled by Settings. (Closed)

Created:
4 years, 10 months ago by gavinp
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/blink.git@minimaster
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow preload scanners to be disabled by Settings. In slow environments, the preload scanners may well be slowing us down by launching too many requests too early. By making them possible to disable, we can experiment with potential benefits to not having them. This will be used in finch trials to study the potential benefit of this and through command line forcing in labs. BUG=None R=jochen@chromium.org,Yoav Weiss,japhet@chromium.org,pmeenan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197660

Patch Set 1 #

Patch Set 2 : add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -14 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 6 chunks +41 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gavinp
jochen: PTAL. japhet, yoav, pmeenan: FYI. My one question: how often will we have to ...
4 years, 10 months ago (2015-06-22 19:47:06 UTC) #1
gavinp
An example dependent CL using the Finch trial is at: https://codereview.chromium.org/1199043002/
4 years, 10 months ago (2015-06-22 21:17:53 UTC) #2
gavinp
My latest upload adds a unit test. jochen, ptal!
4 years, 10 months ago (2015-06-23 14:52:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2015-06-23 14:52:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196193005/20001
4 years, 10 months ago (2015-06-23 15:02:48 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 16:29:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197660

Powered by Google App Engine
This is Rietveld 408576698