Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1196183003: [DevTools] Add screen size and position to Emulation.setDeviceMetricsOverrides. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Add screen size and position to Emulation.setDeviceMetricsOverrides. BUG=393493 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/devtools/protocol.json View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
PTAL
4 years, 10 months ago (2015-06-22 16:58:39 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-22 17:51:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196183003/1
4 years, 10 months ago (2015-06-23 05:45:11 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 07:32:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197634

Powered by Google App Engine
This is Rietveld 408576698