Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1196173004: [GN] Add data_deps support to [android_]java_prebuilt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir) 10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 } 249 }
250 250
251 script = "//build/android/gyp/write_build_config.py" 251 script = "//build/android/gyp/write_build_config.py"
252 depfile = "$target_gen_dir/$target_name.d" 252 depfile = "$target_gen_dir/$target_name.d"
253 inputs = [] 253 inputs = []
254 254
255 deps = [] 255 deps = []
256 if (defined(invoker.deps)) { 256 if (defined(invoker.deps)) {
257 deps += invoker.deps 257 deps += invoker.deps
258 } 258 }
259 if (defined(invoker.data_deps)) {
260 data_deps = invoker.data_deps
261 }
259 262
260 possible_deps_configs = [] 263 possible_deps_configs = []
261 foreach(d, deps) { 264 foreach(d, deps) {
262 dep_gen_dir = get_label_info(d, "target_gen_dir") 265 dep_gen_dir = get_label_info(d, "target_gen_dir")
263 dep_name = get_label_info(d, "name") 266 dep_name = get_label_info(d, "name")
264 possible_deps_configs += [ "$dep_gen_dir/$dep_name.build_config" ] 267 possible_deps_configs += [ "$dep_gen_dir/$dep_name.build_config" ]
265 } 268 }
266 rebase_possible_deps_configs = 269 rebase_possible_deps_configs =
267 rebase_path(possible_deps_configs, root_build_dir) 270 rebase_path(possible_deps_configs, root_build_dir)
268 271
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
814 write_build_config(build_config_target_name) { 817 write_build_config(build_config_target_name) {
815 type = "java_library" 818 type = "java_library"
816 supports_android = _supports_android 819 supports_android = _supports_android
817 requires_android = 820 requires_android =
818 defined(invoker.requires_android) && invoker.requires_android 821 defined(invoker.requires_android) && invoker.requires_android
819 822
820 deps = [] 823 deps = []
821 if (defined(invoker.deps)) { 824 if (defined(invoker.deps)) {
822 deps += invoker.deps 825 deps += invoker.deps
823 } 826 }
827 if (defined(invoker.data_deps)) {
cjhopman 2015/06/23 20:47:05 The data_deps should probably only be added to the
dgn 2015/06/24 10:27:36 Thanks, done.
828 data_deps = invoker.data_deps
829 }
824 build_config = _build_config 830 build_config = _build_config
825 jar_path = _jar_path 831 jar_path = _jar_path
826 if (_supports_android) { 832 if (_supports_android) {
827 dex_path = _dex_path 833 dex_path = _dex_path
828 } 834 }
829 } 835 }
830 836
831 process_java_prebuilt(process_jar_target_name) { 837 process_java_prebuilt(process_jar_target_name) {
832 visibility = [ ":$_template_name" ] 838 visibility = [ ":$_template_name" ]
833 if (_supports_android) { 839 if (_supports_android) {
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 ] 1538 ]
1533 args = [ 1539 args = [
1534 "--depfile", 1540 "--depfile",
1535 rebase_path(depfile, root_build_dir), 1541 rebase_path(depfile, root_build_dir),
1536 "--script-output-path", 1542 "--script-output-path",
1537 rebase_path(generated_script, root_build_dir), 1543 rebase_path(generated_script, root_build_dir),
1538 ] 1544 ]
1539 args += test_runner_args 1545 args += test_runner_args
1540 } 1546 }
1541 } 1547 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698