Issue 1196173003: Bug fix: StyledMarkupSerializer's m_lastClosed can be null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1196173003: Bug fix: StyledMarkupSerializer's m_lastClosed can be null (Closed)

Created:
4 years, 10 months ago by hajimehoshi

Modified:
4 years, 10 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews, blink-reviews-style_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Bug fix: StyledMarkupSerializer's m_lastClosed can be null crrev.com/1188693005 introduced StyledMarkupTraverser and added a new assertion that |m_lastClosed| is not null iff |m_accumulator| is null. This was wrong and this has led crashes. This CL fixes this and adds a test case to reproduce. BUG=502404 TEST=webkit_unit_tests --gtest_filter=StyledMarkupSerializerTest.SytleDisplayNoneAndNewLines Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197627

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	Source/core/editing/StyledMarkupSerializer.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	Source/core/editing/StyledMarkupSerializerTest.cpp	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196173003/1

4 years, 10 months ago (2015-06-23 03:30:34 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-23 05:10:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197627

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages