Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2765)

Issue 1196163006: Fix Javascript tests after commit f55771af6429. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com, Tom Sepez
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Javascript tests after commit f55771af6429. - Return true instead of false. All the other unsupported JS functions return true. - Adjust test expectations accordingly. TBR=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0de47533e05ce7ca80c48156d50a217993e97288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/resources/javascript/document_methods.in View 5 chunks +2 lines, -20 lines 0 comments Download
M testing/resources/javascript/document_methods_expected.txt View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
TBR
5 years, 3 months ago (2015-06-22 22:36:38 UTC) #1
Lei Zhang
5 years, 3 months ago (2015-06-22 22:36:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0de47533e05ce7ca80c48156d50a217993e97288 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698