Source/core/animation/StringKeyframe.cpp - Issue 1196163003: Fix animations not starting on detached elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 1196163003: Fix animations not starting on detached elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/StringKeyframe.cpp

diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp

index 76e4fcf7843944e1b8c7d0418a1923e5d4df1720..82810b8d47303bddf8481ecfb0c0bdd34a809b53 100644

--- a/Source/core/animation/StringKeyframe.cpp

+++ b/Source/core/animation/StringKeyframe.cpp

@@ -117,7 +117,7 @@ StringKeyframe::CSSPropertySpecificKeyframe::CSSPropertySpecificKeyframe(double

void StringKeyframe::CSSPropertySpecificKeyframe::populateAnimatableValue(CSSPropertyID property, Element& element, const ComputedStyle* baseStyle) const

{

- if (!m_animatableValueCache && (baseStyle || !m_value->isInheritedValue()))

+ if (!m_animatableValueCache && (baseStyle || !DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(*m_value)))

m_animatableValueCache = StyleResolver::createAnimatableValueSnapshot(element, baseStyle, property, m_value.get());

}

« no previous file with comments | « Source/core/animation/EffectInput.cpp ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »