Source/core/animation/EffectInput.cpp - Issue 1196163003: Fix animations not starting on detached elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/EffectInput.cpp

Issue 1196163003: Fix animations not starting on detached elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/EffectInput.cpp

diff --git a/Source/core/animation/EffectInput.cpp b/Source/core/animation/EffectInput.cpp

index 82d9db38b47b621e9e29b2f877ea76411d219b3c..03f3893830b27631661f57df7f6db8e3b0ca1afc 100644

--- a/Source/core/animation/EffectInput.cpp

+++ b/Source/core/animation/EffectInput.cpp

@@ -199,9 +199,8 @@ PassRefPtrWillBeRawPtr<EffectModel> EffectInput::convert(Element* element, const

return nullptr;

// TODO(alancutter): Remove this once composited animations no longer depend on AnimatableValues.

- if (!element->inActiveDocument())

- return nullptr;

- element->document().updateLayoutTreeForNodeIfNeeded(element);

+ if (element->inActiveDocument())

+ element->document().updateLayoutTreeForNodeIfNeeded(element);

StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();

StringKeyframeVector keyframes;